This repository was archived by the owner on Feb 3, 2023. It is now read-only.
Conversation
maackle
reviewed
Jul 1, 2020
maackle
reviewed
Jul 1, 2020
| DhtStoreSnapshot { | ||
| holding_map: state.dht().get_holding_map().bare().clone(), | ||
| queued_holding_workflows: state.dht().queued_holding_workflows.clone(), | ||
| in_process_holding_workflows: state.dht().queued_holding_workflows.clone(), |
Collaborator
There was a problem hiding this comment.
Suggested change
| in_process_holding_workflows: state.dht().queued_holding_workflows.clone(), | |
| in_process_holding_workflows: state.dht().in_process_holding_workflows.clone(), |
?
maackle
reviewed
Jul 1, 2020
maackle
reviewed
Jul 1, 2020
maackle
reviewed
Jul 1, 2020
| } | ||
| } | ||
| HoldingWorkflowQueueing::Done => { | ||
| if store.has_exact_in_process_holding_workflow(&self.pending) { |
Collaborator
There was a problem hiding this comment.
Can a PendingValidation ever go straight from Waiting (in the holding_queue) to Done? If not, this is fine, but if so, this isn't checking that.
maackle
approved these changes
Jul 1, 2020
Collaborator
maackle
left a comment
There was a problem hiding this comment.
Looks pretty good! Seems like a state machine sort of model, Waiting <=> Processing => Done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
This PR fixes some long-standing problems in validation:
And one bug in DHT queries:
testing/benchmarking notes
( if any manual testing or benchmarking was/should be done, add notes and/or screenshots here )
followups
( any new tickets/concerns that were discovered or created during this work but aren't in scope for review here )
changelog
documentation