Skip to content
This repository was archived by the owner on Feb 3, 2023. It is now read-only.

Get links on agent id locally#2189

Merged
zippy merged 3 commits intodevelopfrom
get-agent-id-local
May 14, 2020
Merged

Get links on agent id locally#2189
zippy merged 3 commits intodevelopfrom
get-agent-id-local

Conversation

@zippy
Copy link
Copy Markdown
Member

@zippy zippy commented May 11, 2020

PR summary

This PR adds:

  • an optimization of not querying the DHT for get links requests that are placed on a node's own agent id because we must be responsible for holding that part of the DHT.

Note this does not include the optimization for not querying for other links that we are currently holding because sim2h currently does not tell us to stop holding things as neighborhoods change so we always need to check the dht for other links lest what we are holding be out-of-date.

testing/benchmarking notes

( if any manual testing or benchmarking was/should be done, add notes and/or screenshots here )

followups

( any new tickets/concerns that were discovered or created during this work but aren't in scope for review here )

changelog

  • if this is a code change that effects some consumer (e.g. zome developers) of holochain core, then it has been added to our between-release changelog with the format
- summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)

documentation

@zippy zippy marked this pull request as ready for review May 12, 2020 17:24
@zippy zippy changed the base branch from fix-hold-aspect-bugs to develop May 14, 2020 18:10
@zippy zippy merged commit 2b9968e into develop May 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant