MulOverflow#75
Merged
holiman merged 1 commit intoholiman:masterfrom Jun 5, 2020
ledgerwatch:mul_overflow
Merged
Conversation
chfast
approved these changes
Jun 5, 2020
holiman
approved these changes
Jun 5, 2020
Owner
holiman
left a comment
There was a problem hiding this comment.
LGTM, although a benchmark wouldn't hurt too.... :)
It looks like it can be shaved a bit, by not having ph there, and not doing that copy, but instead do the zero-check on the p[4,5,6,7] elements directly ?
Owner
|
I'm fine with merging this though, improvements can always be done later |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I deliberately used full umul for clarity; this operation can be optimised later if need be.