Conversation
Log10 and CmpUint64 (alternate version)
Owner
Author
|
From CI benchmark run #134 : This PR So this is on the order of 3-4x faster. |
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 1628 1646 +18
=========================================
+ Hits 1628 1646 +18 |
holiman
commented
Mar 31, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #134
This PR implements
Log10in what is probably close to the optimal way. Both PRs handle the majority of cases by one lookup based on the bitlength.For the remaining cases, #134 does 0, or, 1, or 2 divisions, and then a few uint64-compares and then it's done.
In this PR, for the remaining cases, we do an additional lookup, and then a comparison, and then we're done.
The drawback of this PR is that it has more precalculated 'persistent memory' hog.
So around 2 K. Not much, but still