Merged
Conversation
cdc3e7b to
78ff00e
Compare
fdd051f to
881f745
Compare
F401 imported but unused
F841 Local variable is assigned to but never used
E402 Module level import not at top of file
E701 Multiple statements on one line (colon)
E713 Test for membership should be `not in`
E722 Do not use bare `except`
E731 Do not assign a `lambda` expression, use a `def`
W293 Blank line contains whitespace
W391 Extra newline at end of file
UP006 Use `dist` instead of `Dist` for type annotation UP006 Use `list` instead of `List` for type annotation
UP007 Use `X | Y` for type annotations
UP009 UTF-8 encoding declaration is unnecessary
UP012 Unnecessary call to `encode` as UTF-8
UP020 Use builtin `open`
skjerns
reviewed
Jan 27, 2025
| data1_read = f.readSignal(0) | ||
| data2_read = f.readSignal(1) | ||
| f._close | ||
| f._close() |
Collaborator
There was a problem hiding this comment.
uh strange that this never gave any access/locking problems
C408 Unnecessary `dict()` call (rewrite as a literal)
C419 Unnecessary list comprehension
ISC001 Implicitly concatenated string literals on one line
ISC002 Implicitly concatenated string literals over multiple lines
ISC003 Explicitly concatenated string should be implicitly concatenated
SIM102 Use a single `if` statement instead of nested `if` statements
SIM201 Use `... != ...` instead of `not ... == ...`
FLY002 Consider f-string instead of string join
PERF401 Use a list comprehension to create a transformed list
FURB110 Replace ternary `if` expression with `or` operator
FURB113 Use `extend(()` instead of repeatedly calling `append()`
FURB167 Use of regular expression alias
FURB171 Membership test against single-item container
FURB188 Prefer `str.removeprefix()` over conditionally replacing with slice.
RUF022 `__all__` is not sorted
RUF027 Possible f-string without an `f` prefix
RUF036 `None` not at the end of the type annotation.
RUF039 First argument to `re.match()` is not raw string RUF039 First argument to `re.search()` is not raw string RUF039 First argument to `re.compile()` is not raw string
Collaborator
|
thanks! looking all good :) is there a necessity to use add a github action for ruff? or any other automated checking tool? |
881f745 to
dc5ca4b
Compare
Contributor
Author
|
Two options:
|
Collaborator
I think it would be nicer to have one dedicated job, that way it is easier to see if errors are caused by cosmetic changes or functional tests failing. Also using the current |
Replace flake8 with ruff.
dc5ca4b to
594972b
Compare
Contributor
Author
|
Updated to run ruff directly from a GitHub Action. |
Collaborator
|
thanks! looking good :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@skjerns Ready for review.