Skip to content

Support Cython 3#248

Merged
skjerns merged 2 commits intoholgern:masterfrom
musicinmybrain:cython3
Nov 12, 2023
Merged

Support Cython 3#248
skjerns merged 2 commits intoholgern:masterfrom
musicinmybrain:cython3

Conversation

@musicinmybrain
Copy link
Copy Markdown
Contributor

@musicinmybrain musicinmybrain commented Nov 10, 2023

Fix a relative cimport and revert the commit that pinned cython<3.0.

@skjerns
Copy link
Copy Markdown
Collaborator

skjerns commented Nov 11, 2023

I assume #233 and #234 has been fixed?

@musicinmybrain
Copy link
Copy Markdown
Contributor Author

musicinmybrain commented Nov 11, 2023

I assume #233 and #234 has been fixed?

Yes, I found that everything was fine (it compiled and the tests passed) after I fixed the cimport:

      cimport c_edf
              ^
      ------------------------------------------------------------
      
      pyedflib/_extensions/_pyedflib.pyx:24:8: 'c_edf.pxd' not found

@skjerns
Copy link
Copy Markdown
Collaborator

skjerns commented Nov 12, 2023

Strange, I could have sworn that I tried that.

Thanks! That fixes it :)

@skjerns skjerns merged commit 3bbcdc0 into holgern:master Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@musicinmybrain @skjerns