Skip to content

introduces → introduced#229

Merged
skjerns merged 1 commit intoholgern:masterfrom
DimitriPapadopoulos:introduces
Jun 28, 2023
Merged

introduces → introduced#229
skjerns merged 1 commit intoholgern:masterfrom
DimitriPapadopoulos:introduces

Conversation

@DimitriPapadopoulos
Copy link
Copy Markdown
Contributor

No description provided.

@skjerns
Copy link
Copy Markdown
Collaborator

skjerns commented Jun 27, 2023

For a cleaner commit history it would be better to include such atomic changes either into other PRs or collect them in a larger PR. I think there are a lot of spelling mistakes to be found, but a general rewrite of the docs would be preferable (there's a bit of outdated stuff there and also more examples could be added) than fixing those minor mistakes.

@DimitriPapadopoulos
Copy link
Copy Markdown
Contributor Author

I understand, but I cannot rewrite the documentation soon, and I find this typo early in the README visible enough to keep me from reading smoothly.

@skjerns
Copy link
Copy Markdown
Collaborator

skjerns commented Jun 28, 2023

Sure, that makes sense!

@skjerns skjerns merged commit b7e4c34 into holgern:master Jun 28, 2023
@DimitriPapadopoulos DimitriPapadopoulos deleted the introduces branch June 28, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants