Merged
Conversation
Collaborator
|
For a cleaner commit history it would be better to include such atomic changes either into other PRs or collect them in a larger PR. I think there are a lot of spelling mistakes to be found, but a general rewrite of the docs would be preferable (there's a bit of outdated stuff there and also more examples could be added) than fixing those minor mistakes. |
Contributor
Author
|
I understand, but I cannot rewrite the documentation soon, and I find this typo early in the README visible enough to keep me from reading smoothly. |
Collaborator
|
Sure, that makes sense! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.