fix: update sphinx resource hyperlink#217
fix: update sphinx resource hyperlink#217skjerns merged 1 commit intoholgern:masterfrom emmanuel-ferdman:wip
Conversation
|
Rebasing against master should fix the |
|
@DimitriPapadopoulos Updated, thanks. |
|
I am afraid you'll have to rebase against the master branch to resolve conflicts. |
|
@DimitriPapadopoulos rebased, thanks |
| pytest --cov=./pyedflib/ --cov-report=xml --cov-config=.coveragerc | ||
| - name: Upload coverage to Codecov | ||
| uses: codecov/codecov-action@v2 | ||
| uses: codecov/codecov-action@v3 |
There was a problem hiding this comment.
Something's wrong here. The master branch already has @v3 instead of @v2.
| runs-on: ubuntu-20.04 | ||
| steps: | ||
| - uses: actions/download-artifact@v2 | ||
| - uses: actions/download-artifact@v3 |
| BDF+ format. | ||
|
|
||
| Use EDFbrowser to view these files: http://www.teuniz.net/edfbrowser/ | ||
| Use EDFbrowser to view these files: https://www.teuniz.net/edfbrowser/ |
DimitriPapadopoulos
left a comment
There was a problem hiding this comment.
I'll try to rebase your branch myself and try to understand the problem.
Signed-off-by: emmanuel-ferdman <emmanuelferdman@gmail.com>
|
Hi @DimitriPapadopoulos, I started over by creating a fresh branch based on the most recent updates in the "master" branch. I made the necessary modifications on this new branch and performed a forced push. This should ensure that everything is now in a valid state. |
|
@skjerns Much better!! I think it is ready for merge. |
|
Please go ahead @DimitriPapadopoulos @skjerns |
|
thanks! |
PR Summary:
The PR contains a fix to the Sphinx broken hyperlink found in the docs.