Remove dependency on the deprecated np.testing.Tester#216
Merged
skjerns merged 1 commit intoholgern:masterfrom Jun 23, 2023
Merged
Remove dependency on the deprecated np.testing.Tester#216skjerns merged 1 commit intoholgern:masterfrom
skjerns merged 1 commit intoholgern:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Today's release of numpy v1.25.0 removed
numpy.testing.Tester(see numpy/numpy#23041). This causes the corresponding import in pyedflib's in__init__.pyto fail. I think this is a remnant of pyedflib using nose for testing so it can likely be removed. If you prefer to keep it, I'd like to suggest introducing an upper bound for the required numpy version.