Conversation
aabef26 to
5477e90
Compare
5477e90 to
a864dc6
Compare
|
Ouch. Somehow I lost the gender branch. Will retry. |
d506586 to
f349cd9
Compare
f349cd9 to
0bf7165
Compare
|
Let me know when you are done then I'll review. Also: Could you sqash the commits after finishing? |
|
The new code should be backwards compatible enough. Not sure if I test the backwards compatibility stuff enough. Can you have a look? |
|
lgtm for testing it would be good to also check that the old functions still return the same values. |
|
About "Due to the edf specifications, only binary assignment is possible": I am not a specialist, but I understand most specialists usually describe biological sex as binary, based on what gametes one produces, while fully endorsing gender diversity. See for example https://doi.org/10.1002/bies.202200173. What could be more subjective is the use of biological sex as a variable of interest in situations where it is not relevant. |
Use deprecated getGender() in addition to getSex() in tests.
|
We do have a similar test in np.testing.assert_equal(f.getSex(), 'Male')
np.testing.assert_equal(f.getGender(), 'Male') # deprecatedI have just added tests to |
|
perfect, I think it's ready to merge now :) |
Fixes #207 .