Skip to content

Update authors.py#210

Merged
skjerns merged 1 commit intoholgern:masterfrom
DimitriPapadopoulos:authors.py
Jun 23, 2023
Merged

Update authors.py#210
skjerns merged 1 commit intoholgern:masterfrom
DimitriPapadopoulos:authors.py

Conversation

@DimitriPapadopoulos
Copy link
Copy Markdown
Contributor

From version 1.10.1 of Scipy:
https://github.com/scipy/scipy/blob/c1ed5ec/tools/authors.py

I started up by trying to remove obsolete Python 2 stuff:

from scipy._lib.six import u, PY3

Ended up sync'ing this vendored file with upstream.

Do you really need it, by the way? The previous version wouldn't have worked with recent versions of SciPy any way, as they lack scipy._lib.six.

From version 1.10.1 of Scipy:
https://github.com/scipy/scipy/blob/c1ed5ec/tools/authors.py

I started up by trying to remove obsolete Python 2 stuff:
	from scipy._lib.six import u, PY3
Ended up sync'ing this vendored file with upstream.
@skjerns
Copy link
Copy Markdown
Collaborator

skjerns commented Jun 2, 2023

tbh I don't even know how this file was used originally. I never touched it since starting to maintain this repo.

@holgern do you know anything?

@skjerns skjerns merged commit 77c05df into holgern:master Jun 23, 2023
@DimitriPapadopoulos DimitriPapadopoulos deleted the authors.py branch June 24, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants