Skip to content

Apply isort#209

Merged
skjerns merged 1 commit intoholgern:masterfrom
DimitriPapadopoulos:isort
Nov 8, 2023
Merged

Apply isort#209
skjerns merged 1 commit intoholgern:masterfrom
DimitriPapadopoulos:isort

Conversation

@DimitriPapadopoulos
Copy link
Copy Markdown
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Jun 2, 2023

Not that I necessarily agree with all isort choices, but the result is consistent and readable imports

@DimitriPapadopoulos DimitriPapadopoulos force-pushed the isort branch 2 times, most recently from 593f362 to ee88a59 Compare June 3, 2023 08:24
@DimitriPapadopoulos DimitriPapadopoulos force-pushed the isort branch 2 times, most recently from c4c3f84 to 0905ef5 Compare July 2, 2023 20:40
@skjerns
Copy link
Copy Markdown
Collaborator

skjerns commented Nov 8, 2023

I think that's a good idea - would you be willing to update this for the current master branch?

@DimitriPapadopoulos
Copy link
Copy Markdown
Contributor Author

DimitriPapadopoulos commented Nov 8, 2023

Done. This time I actually ran ruff check --select I001 --fix instead of isort.

@skjerns skjerns merged commit ae77312 into holgern:master Nov 8, 2023
@DimitriPapadopoulos DimitriPapadopoulos deleted the isort branch November 8, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants