Merged
Conversation
changed every reference and use of Version struct, moved to xPrintf to concatenate numbers with string, undefined minor and patch value is associated with -1.
removed version sort function because wasn't used anymore with its test look for a given version with just one loop instead of three
Owner
|
Hey! Thanks for this, I'm a bit flat out right now but I haven't forgotten about it. I'll review when I can |
|
I apologize in advance for this reply, but the issues in the repository are disabled, @hjbdev Would it be possible to add a feature to enable and install extensions directly?
|
Owner
|
Thanks for this @Lotti! @HerrSammyDE it's a good idea, if I find some time I'll look into it. I've disabled issues to try and push more towards contributions. I've enabled discussions now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It all started with "FindLatestXXX" functions sorting in alphabetical order instead of numeric... and ended with a major rework!
I reworked how the struct Version is used in the program. Then I could go deeper and remove some extra loops that were unnecessary.
Now there is no need to sort versions found on disk and the FindLatestXXX functions works as expected.
I've also removed the test that was testing the version sorting.
Thank you for taking time to review it. I'm still very new to Go, I'll try to write some automated tests next time.