-
Notifications
You must be signed in to change notification settings - Fork 492
Closed
Labels
Description
As we've discussed in #18 the current implementation of FSTemperatureMonitor is somewhat confusing.
Some things I'd suggest doing:
- Rename the whole thing to
LinuxTemperatureMonitor. Neither does thehwmonwork only on file systems (the current code ignores everything except CPUs), nor is it portable to anything except Linux. - Get rid of the configuration file: Hardware is dynamic and the code should reflect this. It's OK to check the list of available sensors (additionally to their values) every second, the additional overhead for you're usual
<10sensors is negligible. - If you do want to keep the configuration file around, use it only to allow the user to set additional temperature sensors and blacklist known bad ones instead of using as "temperature sensor law".
Please let me know what you think about these points.
Reactions are currently unavailable