Skip to content

FSTemperatureMonitor needs some love #21

@ntninja

Description

@ntninja

As we've discussed in #18 the current implementation of FSTemperatureMonitor is somewhat confusing.

Some things I'd suggest doing:

  • Rename the whole thing to LinuxTemperatureMonitor. Neither does the hwmon work only on file systems (the current code ignores everything except CPUs), nor is it portable to anything except Linux.
  • Get rid of the configuration file: Hardware is dynamic and the code should reflect this. It's OK to check the list of available sensors (additionally to their values) every second, the additional overhead for you're usual <10 sensors is negligible.
  • If you do want to keep the configuration file around, use it only to allow the user to set additional temperature sensors and blacklist known bad ones instead of using as "temperature sensor law".

Please let me know what you think about these points.

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions