Verify the first byte when decoding Double/Float#57
Open
fumoboy007 wants to merge 1 commit intohirotakan:masterfrom
Open
Verify the first byte when decoding Double/Float#57fumoboy007 wants to merge 1 commit intohirotakan:masterfrom
Double/Float#57fumoboy007 wants to merge 1 commit intohirotakan:masterfrom
Conversation
Currently, the decoding code for `Double`/`Float` parses the data without first verifying that the data represents a `Double`/`Float`. This is unsafe. For example, a value of type `UInt64` could be decoded as a `Double` with the same bit pattern (but not the same semantic value). Instead, the decoding code should always check the first byte before continuing to parse the data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the decoding code for
Double/Floatparses the data without first verifying that the data represents aDouble/Float. This is unsafe. For example, a value of typeUInt64could be decoded as aDoublewith the same bit pattern (but not the same semantic value).Instead, the decoding code should always check the first byte before continuing to parse the data.