fix(message-signing): add working message verification utility fn#1260
Merged
fix(message-signing): add working message verification utility fn#1260
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #1260 +/- ##
==========================================
- Coverage 64.57% 64.49% -0.09%
==========================================
Files 124 125 +1
Lines 8642 8652 +10
Branches 1854 1859 +5
==========================================
- Hits 5581 5580 -1
- Misses 2818 2828 +10
- Partials 243 244 +1
Continue to review full report at Codecov.
|
janniks
reviewed
May 19, 2022
e24f8c5 to
7b504f6
Compare
7b504f6 to
5b8d9cb
Compare
5b8d9cb to
904500b
Compare
904500b to
832ed9b
Compare
832ed9b to
64e8409
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In changing the signature format, the current docs & blog post has broken code examples.
See leather-io/extension#2435
I copied
parseRecoverableSignaturefrom@stacks/transactions. What's best solution to reuse the fn? Atm encryption doesn't rely on tx package. Should we move to common?Open to other solutions. Would be good to come up with a quick fix though, so users don't hit a wall when trying to use msg signing.