Conversation
src/languages/stan.js
Outdated
| end: /$/, | ||
| relevance: 0, // relevance comes from keywords | ||
| keywords: "include", | ||
| keywords: '#include', |
There was a problem hiding this comment.
Pretty sure this won't work without using $pattern as # isn't a normal keyword character.
There was a problem hiding this comment.
It's parsing as what I want:
Feel free to make changes. I don't know javascript or regex.
There was a problem hiding this comment.
You only seeing the meta highlighting... the keywords isn't working there at all because the "#" is not matched by IDENT_RE, which is what Stan uses for keyword pattern matching.
There was a problem hiding this comment.
I removed keywords and just use the meta highlighting as I think it looks good. Let me know if this goes against the package design philosophy.
There was a problem hiding this comment.
It's probably ok... I'll make a final pass and clean it up later if necessary. The relevancy may have to be tuned now, etc... but it likely looked weird before for some themes so I'm ok changing it.
68df2ea to
54f14dc
Compare
There was a problem hiding this comment.
hey @joshgoebel, commit "clean up grammar" broke the stan syntax highlighting for me. Nothing gets highlighted, reverting this and stan highlighting works.
Edit: It's all from line 10. I'll put that back in but feel free to update to whatever you intended
|
Oh line 10 is broken that's weird. |
Co-authored-by: Josh Goebel <me@joshgoebel.com>
|
🎉 |
|
Thanks all for the great work! |
Resolves #3410
Changes
Updated Stan highlighter for Stan version 2.28
Improvements over previous
Checklist
CHANGES.md