Skip to content

fix: network response payload display bugs#7625

Merged
ccschmitz merged 2 commits intohighlight:mainfrom
jemiluv8:network-payload-bug
Feb 7, 2024
Merged

fix: network response payload display bugs#7625
ccschmitz merged 2 commits intohighlight:mainfrom
jemiluv8:network-payload-bug

Conversation

@jemiluv8
Copy link
Copy Markdown
Contributor

@jemiluv8 jemiluv8 commented Jan 31, 2024 •
edited
Loading

Summary

Update Session Network Request View/Panel to show Array json payload together instead of splitting it down to
various objects. Did same for request and response payload

How did you test this change?

Check the network request payload (that is an array) under a session.
Observe that the formatting is as intended in the issue description.

For example that array payloads are shown as one ('json payload') instead of being broken down
into separate objects and labeled by their index in the array.

BEFORE: What was displayed for array - (The Bug)

Screenshot 2024-01-31 at 3 50 23 PM

AFTER: What we display.

Screenshot 2024-01-31 at 3 59 47 PM

Are there any deployment considerations?

No

Does this work require review from our design team?

No

fixes #6267
/claim #6267

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jan 31, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2c6d1f1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR 
Some errors occurred when validating the changesets config:
The package or glob expression "@highlight-run/rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@jemiluv8 jemiluv8 marked this pull request as ready for review February 1, 2024 14:55
@algora-pbc algora-pbc bot mentioned this pull request Feb 1, 2024
Closed
@Vadman97 Vadman97 requested review from a team and ccschmitz February 3, 2024 02:10
ccschmitz
ccschmitz approved these changes Feb 7, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@ccschmitz ccschmitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code + click test looks great to me! Thank you, @jemiluv8!

@ccschmitz ccschmitz merged commit 0c2447e into highlight:main Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ccschmitz ccschmitz ccschmitz approved these changes

Assignees

No one assigned

Labels

🙋 Bounty claim

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bugs in payload responses on network resource panel

2 participants

@jemiluv8 @ccschmitz