Skip to content

update rrweb#7620

Merged
Vadman97 merged 11 commits intomainfrom
vadim/rrweb-update-repo
Mar 12, 2024
Merged

update rrweb#7620
Vadman97 merged 11 commits intomainfrom
vadim/rrweb-update-repo

Conversation

@Vadman97
Copy link
Member

@Vadman97 Vadman97 commented Jan 30, 2024 •
edited
Loading

Summary

highlight/rrweb#115

hoping this will fix some scroll issues reported by users recently, as well as some canvas recording issues fixed in rrweb

renames our rrweb forks back to the original names to make it easier to rebase in the future.
we will still be using our local fork via the "rrweb": "workspace:*" dependencies in the package.jsons

How did you test this change?

in progress testing via reflame and local deploy
image
image
image

Are there any deployment considerations?

changeset

Does this work require review from our design team?

no

@changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 5aff1a7

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR 
Some errors occurred when validating the changesets config:
The package or glob expression "rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@Vadman97 Vadman97 force-pushed the vadim/rrweb-update-repo branch from 4581809 to e03e55d Compare March 4, 2024 17:36
@Vadman97 Vadman97 force-pushed the vadim/rrweb-update-repo branch from 7dc2ca7 to 6956300 Compare March 5, 2024 08:10
@Vadman97 Vadman97 requested review from a team and ccschmitz and removed request for a team March 5, 2024 08:11
@Vadman97 Vadman97 force-pushed the vadim/rrweb-update-repo branch from 6956300 to ebb5131 Compare March 5, 2024 08:13
@Vadman97 Vadman97 marked this pull request as ready for review March 5, 2024 19:12
@reflame reflame bot had a problem deploying to Preview March 5, 2024 19:35 Failure
@Vadman97 Vadman97 force-pushed the vadim/rrweb-update-repo branch from 3330cc3 to 4ed5b83 Compare March 5, 2024 19:36
@reflame reflame bot had a problem deploying to Preview March 5, 2024 19:36 Failure
ccschmitz
ccschmitz reviewed Mar 6, 2024
View reviewed changes
@ccschmitz ccschmitz self-requested a review March 6, 2024 20:16
ccschmitz
ccschmitz approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@ccschmitz ccschmitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM 👍 - I did try click testing and hit an error trying to run yarn.

image

Guessing this is just a workspace configuration issue. Approving, but maybe want to take a second look at that before merging.

@Vadman97 Vadman97 force-pushed the vadim/rrweb-update-repo branch from 4ed5b83 to 0233f56 Compare March 12, 2024 18:02
@Vadman97
Copy link
Member Author

Vadman97 commented Mar 12, 2024

@ccschmitz since the rrweb change renames the package, it requires pulling in the latest submodule to get the frontend to build. git submodule update --init

will share that with the team once this is merged.

@Vadman97 Vadman97 enabled auto-merge (squash) March 12, 2024 18:08
@Vadman97 Vadman97 force-pushed the vadim/rrweb-update-repo branch from f289787 to 2097b56 Compare March 12, 2024 18:19
@Vadman97 Vadman97 force-pushed the vadim/rrweb-update-repo branch from 2097b56 to 0b689c9 Compare March 12, 2024 19:45
@Vadman97 Vadman97 merged commit 23a01e3 into main Mar 12, 2024
@Vadman97 Vadman97 deleted the vadim/rrweb-update-repo branch March 12, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ccschmitz ccschmitz ccschmitz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Vadman97 @ccschmitz