Skip to content

Gitlab integration#7435

Merged
SpennyNDaJets merged 8 commits intohighlight:mainfrom
jemiluv8:gitlab-integration
Jan 16, 2024
Merged

Gitlab integration#7435
SpennyNDaJets merged 8 commits intohighlight:mainfrom
jemiluv8:gitlab-integration

Conversation

@jemiluv8
Copy link
Copy Markdown
Contributor

@jemiluv8 jemiluv8 commented Jan 7, 2024 •
edited
Loading

Add gitlab integration to support creating gitlab issues from highlight ui

fixes #7146
/claim #7146

Summary

How did you test this change?

  • Go to integrations page and go through the flow for adding gitlab integration
  • Verify that after authorizing our app, gitlab integration is marked as active
  • Verify that you can "remove" the gitlab integration
  • Create gitlab issues from highlight ui - error comment and session comment
  • Ensure that clicking the link to gitlab issue takes you to the relevant task description

DEMO VIDEO FOR SETTING UP INTEGRATION AND CREATING GITLAB ISSUE FROM ERROR COMMENT

https://www.loom.com/share/19c4eb24b1304c0eaa274afe54a6e4a5

DEMO VIDEO - CREATING GITLAB ISSUE FROM SESSION COMMENT (New and Existing). Plus viewing issue link

https://www.loom.com/share/6c199775ca354e07bfc3364b1d03cc13?sid=ff7dc45b-779d-4d0a-8309-7a9f243fcefb

Are there any deployment considerations?

Two new environment variables are needed for jira integration support

  • GITLAB_CLIENT_ID
  • GITLAB_CLIENT_SECRET

GITLAB OAUTH APPLICATION SCOPE

read_api+api

These can be added in app configuration under developer console
https://gitlab.com/-/user_settings/applications

GITLAB OAUTH APPLICATION TYPE

Gitlab supports three(3) types of oauth applications

  • User Owned
  • Group Owned
  • Instance Owned

The application type used for this project is User Owned.

Does this work require review from our design team?

Yes. This requires a design review. Below are the modified views.
Screenshot 2024-01-07 at 7 32 09 PM

Screenshot 2024-01-07 at 7 33 45 PM

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jan 7, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: e1de1fd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR 
Some errors occurred when validating the changesets config:
The package or glob expression "@highlight-run/rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@algora-pbc algora-pbc bot mentioned this pull request Jan 7, 2024
Closed
jemiluv8
jemiluv8 commented Jan 7, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@jemiluv8 jemiluv8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mayberryzane, I just completed a self review.
Look forward to fixing any issues you might encounter

@Vadman97 Vadman97 requested review from a team and SpennyNDaJets and removed request for a team January 8, 2024 16:56
SpennyNDaJets
SpennyNDaJets approved these changes Jan 11, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@SpennyNDaJets SpennyNDaJets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! To confirm the steps we need to do before shipping this to production:

  • create a company GitLab account (don't need to upload any code)
  • Add the following credentials linked to our GitLab account to our environment variables
    • GITLAB_CLIENT_ID
    • GITLAB_CLIENT_SECRET
      c.c. @Vadman97

@SpennyNDaJets SpennyNDaJets merged commit 18c716f into highlight:main Jan 16, 2024
@SpennyNDaJets
Copy link
Copy Markdown
Contributor

SpennyNDaJets commented Jan 16, 2024 •
edited
Loading

Able to confirm on main, but debugging an issue on prod:
Client authentication failed due to unknown client, no client authentication included, or unsupported authentication method.

Seems to be related to client id not being set, so no more work should be needed here 🙌

Main working
Screenshot 2024-01-16 at 3 05 41 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SpennyNDaJets SpennyNDaJets SpennyNDaJets approved these changes

Assignees

No one assigned

Labels

🙋 Bounty claim

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GitLab integration

2 participants

@jemiluv8 @SpennyNDaJets