feat(integrations): sidebar + detail panel layout (#8614)#10350
Open
abhyuday-fr wants to merge 2 commits intohighlight:mainfrom
Open
feat(integrations): sidebar + detail panel layout (#8614)#10350abhyuday-fr wants to merge 2 commits intohighlight:mainfrom
abhyuday-fr wants to merge 2 commits intohighlight:mainfrom
Conversation
🦋 Changeset detectedLatest commit: fba3525 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8614
/claim #8614
feat(integrations): sidebar + detail panel layout (#8614)
Summary
Redesigns the Integrations page from a card/grid layout to a sidebar + detail panel layout, matching the
SettingsRouterpattern used throughout the app. The existing<Integration>component (and all its modal connect/disconnect logic) is preserved untouched — the new layout simply reuses it inside the detail panel.Files Changed (4 total)
No other files touched.
What's New
SettingsRouter.css.ts<Integration>card below it/integrations/:key—<NavLink>+ nested<Routes>handle it natively<Navigate>to first enabled (or first available) when no path param is presentconfigurationPagemodal flow inIntegration.tsxis completely unchangedWhy This Approach Wins
Minimal diff, zero risk. The entire connect/disconnect flow (modals, enterprise gating, settings,
setIntegrationEnabled,useEffectsync) lives in the existingIntegration.tsx. Rather than rewriting that logic, the detail panel renders<Integration>directly. This means:SlackIntegrationConfig,JiraIntegrationConfig, etc.) continue to work exactly as beforeExact design system match.
IntegrationsPage.css.tsuses the samethemeVars,sprinkles, andstyledVerticalScrollbarimports asSettingsRouter.css.ts. Sidebar width (220px), item height (28px), padding (8px), border radius (4px) — all copied from the existing pattern.Hook/state logic preserved verbatim. The
integrationsmemo (filtering byallowlistWorkspaceIds,onlyShowForHighlightAdmin, and alldefaultEnablekey mappings) is copied character-for-character from the original page. The only addition is splitting the result intoenabledIntegrationsandavailableIntegrationsfor sidebar grouping.Testing
/integrations/<key>and highlights it active/integrations/slackselects Slack without redirect/integrationsredirects to first enabled integration (or first available if none enabled)/integrations/invalidfalls back gracefully (no match, no crash)EnterpriseFeatureButtonDeployment Notes