Skip to content

Cleanup Java SDK#8541

Merged
Vadman97 merged 3 commits intohighlight:mainfrom
NgLoader:feat-java-cleanup
Oct 16, 2024
Merged

Cleanup Java SDK#8541
Vadman97 merged 3 commits intohighlight:mainfrom
NgLoader:feat-java-cleanup

Conversation

@NgLoader
Copy link
Copy Markdown
Contributor

@NgLoader NgLoader commented May 11, 2024 •
edited
Loading

chore: cleanup some classes
fix: code spacing in some classes

Summary

Cleanup the java sdk and add some missing commands.
Also made the servername optionaly.

How did you test this change?

Localy

Are there any deployment considerations?

No

Does this work require review from our design team?

No

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented May 11, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8a2c729

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR 
Some errors occurred when validating the changesets config:
The package or glob expression "rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/all" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/record" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/replay" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/packer" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/rrweb-plugin-canvas-webrtc-record" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/rrweb-plugin-canvas-webrtc-replay" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/rrweb-plugin-console-record" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/rrweb-plugin-console-replay" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/rrweb-plugin-sequential-id-record" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/rrweb-plugin-sequential-id-replay" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/utils" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@Vadman97
Copy link
Copy Markdown
Member

Vadman97 commented May 13, 2024

/tip $100

@Vadman97 Vadman97 self-requested a review May 13, 2024 21:32
@algora-pbc
Copy link
Copy Markdown

algora-pbc bot commented May 13, 2024

@NgLoader: You just got a $100 tip! 👉 Complete your Algora onboarding to collect your payment.

Vadman97
Vadman97 approved these changes May 13, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Vadman97 Vadman97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good so far!

@Vadman97 Vadman97 self-assigned this May 13, 2024
@NgLoader NgLoader marked this pull request as ready for review May 17, 2024 16:33
@NgLoader
Copy link
Copy Markdown
Contributor Author

NgLoader commented May 17, 2024 •
edited
Loading

Hey, sry for the delay.
I had planed some more small changes but will merge them inside some other PRs.
Need to do some other work first but soon I will commit some new implementations (framework / logger support) in java.

@algora-pbc
Copy link
Copy Markdown

algora-pbc bot commented May 18, 2024

🎉🎈 @NgLoader has been awarded $100! 🎈🎊

@Vadman97
Copy link
Copy Markdown
Member

Vadman97 commented Oct 16, 2024

@NgLoader could you please rebase on main so we can update the checks and merge?

@NgLoader @Vadman97
chore: cleanup code
9f71db0 
chore: format code spacing
@NgLoader @Vadman97
chore: format
6552951
@NgLoader @Vadman97
chore: format pom.xml
8a2c729 
chore: removed duplicated code
@Vadman97 Vadman97 enabled auto-merge (squash) October 16, 2024 15:06
@Vadman97 Vadman97 disabled auto-merge October 16, 2024 17:58
@Vadman97 Vadman97 merged commit 10641a3 into highlight:main Oct 16, 2024
@NgLoader NgLoader deleted the feat-java-cleanup branch October 17, 2024 08:29
giraffekey pushed a commit to giraffekey/highlight that referenced this pull request Nov 21, 2024
@NgLoader @giraffekey
Cleanup Java SDK (highlight#8541)
959234a 
chore: cleanup some classes
fix: code spacing in some classes

## Summary
Cleanup the java sdk and add some missing commands.
Also made the ``servername`` optionaly.
<!--
Ideally, there is an attached GitHub issue that will describe the "why".

If relevant, use this section to call out any additional information
you'd like to _highlight_ to the reviewer.
-->

## How did you test this change?
Localy
<!--
Frontend - Leave a screencast or a screenshot to visually describe the
changes.
-->

## Are there any deployment considerations?
No
<!--
 Backend - Do we need to consider migrations or backfilling data?
-->

## Does this work require review from our design team?
No
<!--
 Request review from julian-highlight / our design team 
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Vadman97 Vadman97 Vadman97 approved these changes

Assignees

@Vadman97 Vadman97

Labels

💰 Rewarded

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NgLoader @Vadman97