Skip to content

Fixed #22845, choppy tooltip animation on pie charts#22846

Merged
TorsteinHonsi merged 2 commits into
masterfrom
bugfix/22845-choppy-tooltip
Mar 28, 2025
Merged

Fixed #22845, choppy tooltip animation on pie charts#22846
TorsteinHonsi merged 2 commits into
masterfrom
bugfix/22845-choppy-tooltip

Conversation

@TorsteinHonsi

@TorsteinHonsi TorsteinHonsi commented Mar 25, 2025 •
edited by hubertkozik
Loading

Copy link
Copy Markdown
Collaborator

Fixed #22845, a regression causing choppy tooltip animation on pie charts and some other chart types where followPointer was set to true.

@TorsteinHonsi

TorsteinHonsi commented Mar 25, 2025

Copy link
Copy Markdown
Collaborator Author

Reviewer note:
I ended up disabling animation altogether when followPointer. I tested with a distance check, running animation only when moving larger distances, but it was still choppy. The animation before the regression was also so quick that it was barely noticeable, so I think this is a fair tradeoff. Besides, in a pie chart or map, where this configuration is most common, the tooltip is not likely to jump over a distance.

@highsoft-bot

highsoft-bot commented Mar 25, 2025

Copy link
Copy Markdown
Collaborator

Visual test results - No difference found

@highsoft-bot

highsoft-bot commented Mar 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

File size comparison

Sizes for compiled+gzipped (bold) and compiled files.

master candidate difference
highcharts.js 99.0 kB
271.5 kB		 99.0 kB
271.6 kB		 -2 B
12 B
highstock.js 132.6 kB
371.8 kB		 132.6 kB
371.8 kB		 -2 B
12 B
highmaps.js 124.7 kB
346.2 kB		 124.6 kB
346.2 kB		 -2 B
12 B
highcharts-gantt.js 137.6 kB
386.0 kB		 137.6 kB
386.1 kB		 -2 B
12 B

kamil-musialowski
kamil-musialowski approved these changes Mar 26, 2025
View reviewed changes

@kamil-musialowski kamil-musialowski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good, thanks!

@TorsteinHonsi TorsteinHonsi added Changelog: Bugfix Use on PR to add description as a bugfix in the generated changelog. Priority: Blocker labels Mar 26, 2025
@TorsteinHonsi TorsteinHonsi merged commit bcce15d into master Mar 28, 2025
@TorsteinHonsi TorsteinHonsi deleted the bugfix/22845-choppy-tooltip branch March 28, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kamil-musialowski kamil-musialowski kamil-musialowski approved these changes

Assignees

No one assigned

Labels

Changelog: Bugfix Use on PR to add description as a bugfix in the generated changelog. Priority: Blocker

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tooltip animation when followPointer is set to true

3 participants

@TorsteinHonsi @highsoft-bot @kamil-musialowski