Skip to content

dash/firefox-drag#21395

Merged
sebastianbochan merged 2 commits into
masterfrom
dash/firefox-drag
Jul 1, 2024
Merged

dash/firefox-drag#21395
sebastianbochan merged 2 commits into
masterfrom
dash/firefox-drag

Conversation

@karolkolodziej

@karolkolodziej karolkolodziej commented Jun 25, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Fixed #21189, dragging and dropping elements from the sidebar and inside the dashboard was impossible in Firefox.

  • sidebar
  • context detection

@karolkolodziej karolkolodziej added Changelog: Bugfix Use on PR to add description as a bugfix in the generated changelog. Product: Highcharts Dashboards labels Jun 25, 2024
@karolkolodziej karolkolodziej self-assigned this Jun 25, 2024
@highsoft-bot

highsoft-bot commented Jun 25, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

File size comparison

Sizes for compiled+gzipped (bold) and compiled files.

master candidate difference
dashboards/modules/layout.js 12.3 kB
48.4 kB		 12.3 kB
48.7 kB		 70 B
326 B

@highsoft-bot

highsoft-bot commented Jun 25, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Dashboard visual diffs

Visual differences found in:

  • /home/runner/work/highcharts/highcharts/cypress/snapshots/actual/test/cypress/dashboards/visual/dashboards-demo-minimal-loaded.png

See artifacts in the run summary for screenshots

@highsoft-bot

highsoft-bot commented Jun 25, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Lighthouse report

dashboards-demo-minimal.json

Reference Proposed Diff
performance – score 1 1 0.00
first-contentful-paint – score 1 1 0.00
first-contentful-paint – milliseconds 188.06 188.06 0.00
first-meaningful-paint – score 1 1 0.00
first-meaningful-paint – milliseconds 452.18 443.16 -9.02
dom-size – score 1 1 0.00
dom-size – elements 344 344 0.00

@highsoft-bot

highsoft-bot commented Jun 25, 2024

Copy link
Copy Markdown
Collaborator

Visual test results - No difference found

@highsoft-bot

highsoft-bot commented Jun 25, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Benchmark report - Dashboards

benchmarks/Dashboards/DataPool-CSV-constructor.bench.ts

Sample size This PR avg (ms) master avg (ms) Diff Percent diff
2500000 0.16 0.16 0 3%
See all
Sample size This PR avg (ms) master avg (ms) Diff Percent diff
100 0.16 0.17 -0.01 -4%
1000 0.16 0.16 0 -1%
10000 0.16 0.16 0 -2%
100000 0.16 0.16 0 0%
1000000 0.16 0.17 -0.01 -6%
2500000 0.16 0.16 0 3%

benchmarks/Dashboards/DataTable-loading-rows.bench.ts

Sample size This PR avg (ms) master avg (ms) Diff Percent diff
2500000 730.63 732.47 -1.84 0%
See all
Sample size This PR avg (ms) master avg (ms) Diff Percent diff
100 0.28 0.29 -0.01 -4%
1000 0.52 0.51 0.01 3%
10000 3.37 3.63 -0.26 -7.000000000000001%
100000 23.18 20.76 2.41 12%
1000000 285.21 287.89 -2.68 -1%
2500000 730.63 732.47 -1.84 0%

benchmarks/Dashboards/DataTable-loading-columns.bench.ts

Sample size This PR avg (ms) master avg (ms) Diff Percent diff
2500000 15.89 15.73 0.16 1%
See all
Sample size This PR avg (ms) master avg (ms) Diff Percent diff
100 0.23 0.24 0 -2%
1000 0.24 0.23 0.01 2%
10000 0.41 0.27 0.14 50%
100000 2.28 2.24 0.04 2%
1000000 8.34 8.78 -0.44 -5%
2500000 15.89 15.73 0.16 1%

@karolkolodziej karolkolodziej marked this pull request as ready for review June 26, 2024 11:37
@sebastianbochan sebastianbochan merged commit 1db290f into master Jul 1, 2024
@bre1470 bre1470 modified the milestones: Next, Dashboards-Next Jul 2, 2024
@KacperMadej KacperMadej deleted the dash/firefox-drag branch November 12, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sebastianbochan sebastianbochan sebastianbochan approved these changes

@ddragula ddragula ddragula approved these changes

+1 more reviewer

@jomar-honsi jomar-honsi jomar-honsi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@karolkolodziej karolkolodziej

Labels

Changelog: Bugfix Use on PR to add description as a bugfix in the generated changelog. Product: Highcharts Dashboards

Projects

None yet

Milestone

Dashboards v2.3.0

Development

Successfully merging this pull request may close these issues.

Dashboards drag & drop doesn't work on firefox

6 participants

@karolkolodziej @highsoft-bot @sebastianbochan @jomar-honsi @ddragula @bre1470