Skip to content

bugfix/19002-a11y-stripped-signs#19136

Merged
TorsteinHonsi merged 1 commit into
masterfrom
bugfix/19002-a11y-stripped-signs
Jun 22, 2023
Merged

bugfix/19002-a11y-stripped-signs#19136
TorsteinHonsi merged 1 commit into
masterfrom
bugfix/19002-a11y-stripped-signs

Conversation

@jedrzejruta

Copy link
Copy Markdown
Contributor

Fixed #19002, with a11y enabled < sign was stripped, causing issues with screen readers.

@jedrzejruta jedrzejruta added Changelog: Bugfix Use on PR to add description as a bugfix in the generated changelog. a11y Accessibility related. labels Jun 12, 2023
@jedrzejruta jedrzejruta self-assigned this Jun 12, 2023
@highsoft-bot

Copy link
Copy Markdown
Collaborator

File size comparison

Sizes for compiled+gzipped (bold) and compiled files.

master candidate difference
modules/accessibility.js 34.4 kB
120.7 kB
34.5 kB
120.9 kB
108 B
274 B

@highsoft-bot

Copy link
Copy Markdown
Collaborator

Visual test results - No difference found

@TorsteinHonsi

Copy link
Copy Markdown
Collaborator

Pending @oysteinmoseng 's review

@oysteinmoseng oysteinmoseng left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TorsteinHonsi TorsteinHonsi merged commit c617322 into master Jun 22, 2023
@highsoft-bot highsoft-bot added this to the Next milestone Jun 22, 2023
@TorsteinHonsi TorsteinHonsi deleted the bugfix/19002-a11y-stripped-signs branch June 22, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a11y Accessibility related. Changelog: Bugfix Use on PR to add description as a bugfix in the generated changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Screen reader stops anouncing description after encountering certain characters.

5 participants