[Graph] Fix CompiledGraph aliasing bug#384
Merged
yaoyaoding merged 6 commits intohidet-org:mainfrom Dec 5, 2023
Merged
Conversation
yaoyaoding
reviewed
Dec 2, 2023
Comment on lines
+211
to
+214
| if sig.alias is not None: | ||
| outputs.append(outputs[sig.alias]) | ||
| continue | ||
|
|
Member
There was a problem hiding this comment.
We can do the checking alternatively like
if exec_idx in self.graph_execution.inputs_index:
outputs.append(inputs[self.graph_execution.inputs_index.index(exec_idx)])
elif exec_idx in self.graph_execution.weights_index:
outputs.append(self.weights[self.graph_execution.weights_index.index(exec_idx)])
elif exec_idx != self.graph_execution.outputs_index.index(exec_idx): # <--------
outputs.append(outputs[self.graph_execution.outputs_index.index(exec_idx)])
else:
so we do not need to modify the graph building process or an alias attribute.
How do you think @Aalanli ?
Contributor
Author
There was a problem hiding this comment.
The suggested change doesn't work, but I see how to fix it.
Yeah, I think this way is better as well.
yaoyaoding
reviewed
Dec 2, 2023
Member
|
Thanks @Aalanli ! |
Member
|
Could you also add the test to the repo? |
Member
|
Thanks @Aalanli ! |
This was referenced Dec 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some graphs produce output tensors that alias. In the original case, the outputs of the aliasing tensors would be undefined (the result of empty). This PR fixes that by aliasing the outputs as well.
For example this script originally outputs garbage in the second tensor