[Operator] Composite Elementwise Operation#337
Merged
hjjq merged 5 commits intohidet-org:mainfrom Aug 1, 2023
Merged
Conversation
yaoyaoding
approved these changes
Aug 1, 2023
Member
yaoyaoding
left a comment
There was a problem hiding this comment.
Thanks @hjjq, it looks good to me!
python/hidet/graph/ops/arithmetic.py
Outdated
Comment on lines
+48
to
+51
| self.lhs = lhs | ||
| self.rhs = rhs | ||
| self.out = out | ||
| self.name = name |
Member
There was a problem hiding this comment.
Better to add some type hints to increase the readability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assuming
U1andU2are unary elementwise operators, andBis a binary elementwise operator.Introduce a new fused operator called Composite Elementwise Operation, where
comp_elemwise(x, U1, U2, B) = B(U1(x), U2(x)).Also add subgraph rewrite rule. This allows for more fusion opportunity.