Merged
Conversation
added 2 commits
July 21, 2023 12:06
Member
added 2 commits
July 22, 2023 12:55
Contributor
Author
|
Hi @yaoyaoding, yes, the numerical issues have been resolved. I noticed slight one character differences between torch and hidet output on llama2. But on a layer by layer basis, the activations are allclose. |
Member
|
Thanks @Aalanli. It's fine that the output has very slight output difference. Feel free to merge this PR after passing the ci. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added some changes to support llama2. Not tested for numerical accuracy, waiting for reduce fix.