Merged
Conversation
Contributor
Author
|
The changes seems to pass, will merge. CC @yaoyaoding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_is_exiting is set to True by at_exit, and False in the usual case, the logic currently is flipped.
Now that is_exiting is working properly, we are actually clearning up memory. As a result, I found a different bug where dummy input creation is not properly handled for different data types (e.g. int types that are used for indexing)
This was not found before because we are re-using old memory regions and somehow these old allocations had proper values in them.