[FixBug] Don't instantiate symbol for primitive functions#291
Merged
yaoyaoding merged 2 commits intohidet-org:mainfrom Jun 26, 2023
Merged
[FixBug] Don't instantiate symbol for primitive functions#291yaoyaoding merged 2 commits intohidet-org:mainfrom
yaoyaoding merged 2 commits intohidet-org:mainfrom
Conversation
added 2 commits
June 23, 2023 22:23
Member
|
Thanks @hjjq! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if a primitive function calls a primitive function, the
instantiate_symbolspass will update the correspondinghidet.ir.primitives.func.PrimitiveFunctionRegistry.functionin-place (I am not sure exactly how it's done, but this is what I observed), adding symbol variables to its parameters. The primitive function pool is a global variable, therefore this effect is cumulative across tuning candidates. So while candidate 0 will have no problem, candidate 1 will have two extra copies of symbol params, and so on, leading to compile errors.Since primitive functions do not need symbol vars, a quick fix is just to not instantiate any symbols for them.