Merged
Conversation
yaoyaoding
approved these changes
Jun 6, 2023
Member
yaoyaoding
left a comment
There was a problem hiding this comment.
Hi @Aalanli,
Thanks for the great tool! I left some minor comments.
| @@ -0,0 +1,31 @@ | |||
| # %% | |||
Member
There was a problem hiding this comment.
We also have the color support at
hidet/python/hidet/utils/py.py
Lines 61 to 121 in a1bd18c
We can consider reusing it.
| @@ -0,0 +1,91 @@ | |||
| # Licensed under the Apache License, Version 2.0 (the "License"); | |||
Member
There was a problem hiding this comment.
Better to move the tests classes.py and functions.py to tests/utils/model_translator/ folder.
Add whitelist to avoid user input
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See README and examples