Rename MysqlConfig property, correct fromUri default, and remove redundant code#6
Merged
Merged
Conversation
rcalicdan
approved these changes
May 14, 2026
rcalicdan
left a comment
Member
There was a problem hiding this comment.
Thanks for the refactor and cleaning up the codebase..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5
Six of the seven approved changes from the issue. Point 8 (adding
finaltoConnection) is not included -Mockery::mock(Connection::class)intests/Pest.phprequires subclassing to build the test double andfinalblocks that. It needs an interface extraction before it can land.MysqlConfig::fromUri()was defaultingenableServerSideCancellationtotrue, inconsistent with the constructor andfromArray()which both default tofalse. Corrected.new SplQueue()allocation inreleaseClean()that replaced the existing queue object when it was already empty.$this->activeConnections = 0incheckShutdownComplete(). Active connections are already zero at that point.$MysqlConfigproperty onPoolManagerto$mysqlConfigto match PSR naming.createNewConnection().healthCheck()into a single closure shared by both the resolve and reject callbacks.fromUri()default correction.