This repository was archived by the owner on Dec 1, 2024. It is now read-only.
Let Github Action update composer.json when changing latest breaking HHVM version#470
Merged
Conversation
d5589f6 to
32682be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, Github Action created #462, which did not update composer.json. As a result, the release tag that includes #462 breaks dependent of HHAST according to https://github.com/hhvm/definition-finder/runs/6760337843?check_suite_focus=true
This PR let the Github Action update composer.json when changing latest breaking HHVM version, in case of dependent breakage in the future.