Skip to content
This repository was archived by the owner on Dec 1, 2024. It is now read-only.

Migrate away from d and v array#457

Merged
Atry merged 5 commits into
hhvm:mainfrom
lexidor:migrate-away-from-d-and-v-array
May 16, 2022
Merged

Migrate away from d and v array#457
Atry merged 5 commits into
hhvm:mainfrom
lexidor:migrate-away-from-d-and-v-array

Conversation

@lexidor

@lexidor lexidor commented Apr 27, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@lexidor

lexidor commented Apr 27, 2022

Copy link
Copy Markdown
Contributor Author

MacOS failure is because of a failed hhvm install:

Error: hhvm-4.159: SHA256 mismatch
  Expected: f2a61316967b82b0ac2dc5f4c7fa995cc82d0f5ea3397c09ef8f965450612c75
    Actual: 26379e68f39d059dcce7d58cb97c3f251de0dc17d4e6f0b7ca1618502ddcbee5

@Atry

Atry commented Apr 30, 2022

Copy link
Copy Markdown
Contributor

We should revert hhvm/homebrew-hhvm#152

@lexidor

lexidor commented Apr 30, 2022

Copy link
Copy Markdown
Contributor Author

CI run

@lexidor lexidor closed this Apr 30, 2022
@lexidor lexidor reopened this Apr 30, 2022
@Atry Atry closed this May 2, 2022
@Atry Atry reopened this May 2, 2022

@Atry Atry left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@lexidor

lexidor commented May 13, 2022

Copy link
Copy Markdown
Contributor Author

CI run

@lexidor lexidor closed this May 13, 2022
@lexidor lexidor reopened this May 13, 2022

@Atry Atry left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are sophisticated! 👍

@Atry Atry merged commit 918f590 into hhvm:main May 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants