This repository was archived by the owner on Dec 1, 2024. It is now read-only.
Make "builtinLinters": "all" mean all linters, but...#450
Merged
Conversation
'default' and 'all' "builtinLinters": "all" mean all linters, but...
Contributor
Author
|
Got to figure out why hhvm-nightly takes 6 hours and gets killed by github. |
Contributor
|
Close and reopen this PR to trigger the CI |
Contributor
Author
|
Merge conflict requires running codegen again to fix the file hash in token-from-data.hack. I will have to do that some other day. |
In hhast `'all'` doesn't really mean `all`. Let's fix that. FinalOrAbstractClass and DataProviderTypesLinter are missing. I will add FinalOrAbstractClass in the next commit.
Contributor
Author
|
Running CI |
Atry
approved these changes
May 3, 2022
Contributor
|
Looks good to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
, but...
I have intentionally not added DataProviderTypesLinter. This was a well intended linter, but it does some things it shouldn't do. Its idea of isSafeAssignment is misguided.