Skip to content

fix: handle charset in auto parseAs detection#1296

Merged
mrlubos merged 1 commit into
mainfrom
fix/client-fetch-parse-as-charset
Nov 17, 2024
Merged

fix: handle charset in auto parseAs detection#1296
mrlubos merged 1 commit into
mainfrom
fix/client-fetch-parse-as-charset

Conversation

@mrlubos

@mrlubos mrlubos commented Nov 17, 2024

Copy link
Copy Markdown
Member

Closes #1288

@bolt-new-by-stackblitz

bolt-new-by-stackblitz Bot commented Nov 17, 2024

Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@changeset-bot

changeset-bot Bot commented Nov 17, 2024 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 4c853d0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@hey-api/client-fetch Patch
@example/openapi-ts-fastify Patch
@example/openapi-ts-fetch Patch
@example/openapi-ts-tanstack-angular-query-experimental Patch
@example/openapi-ts-tanstack-react-query Patch
@example/openapi-ts-tanstack-svelte-query Patch
@example/openapi-ts-tanstack-vue-query Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Nov 17, 2024 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 17, 2024 6:48pm

@mrlubos mrlubos marked this pull request as ready for review November 17, 2024 15:48
@mrlubos mrlubos force-pushed the fix/client-fetch-parse-as-charset branch from 7259168 to 4c853d0 Compare November 17, 2024 18:48
@codecov

codecov Bot commented Nov 17, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.96%. Comparing base (ee7a411) to head (4c853d0).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1296   +/-   ##
=======================================
  Coverage   66.96%   66.96%           
=======================================
  Files         136      136           
  Lines       20134    20134           
  Branches     1791     1791           
=======================================
  Hits        13482    13482           
  Misses       6648     6648           
  Partials        4        4
Flag Coverage Δ
unittests 66.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrlubos mrlubos merged commit 2822bc4 into main Nov 17, 2024
@mrlubos mrlubos deleted the fix/client-fetch-parse-as-charset branch November 17, 2024 18:55
@github-actions github-actions Bot mentioned this pull request Nov 17, 2024
Merged
@zilvinas-abromavicius-surfshark

zilvinas-abromavicius-surfshark commented Dec 23, 2024

Copy link
Copy Markdown

Sorry for no response, don't use this account much. Looking at the PR, it seems that this case will now be handled. Thank you for the change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

@hey-api/client-fetch Returns response as Blob for Accept: "application/ld+json"

2 participants

@mrlubos @zilvinas-abromavicius-surfshark