Dependency policies#1622
Open
ericmj wants to merge 10 commits into
Open
Conversation
Dependency ReviewThe following issues were found:
License Issuesmix.exs
OpenSSF Scorecard
Scanned Files
|
Ch4s3
reviewed
Jun 2, 2026
| attr :value, :string, default: "1" | ||
| attr :rest, :global | ||
|
|
||
| def toggle_switch(assigns) do |
Contributor
There was a problem hiding this comment.
there's another similar-ish toggle in hexpm_web/components/pricing.ex, billing_toggle. At some point it may be worth having a generic toggle component in the app.
c0c0a9d to
7936750
Compare
7936750 to
246aff6
Compare
- Make policy names immutable after creation so the signed bucket object key never changes and old objects can't be orphaned; the editable name field and rename action are removed from the edit form. - Reject reserved policy names (new, package-suggestions, version-suggestions) that would shadow the policy sub-routes. - Scope the policy rebuild advisory lock to the policy id so rebuilds of different policies run in parallel. - Replace the per-policy audit-log count on the list page with a single grouped query. - Hide the save and delete affordances from non-admins on the edit form and show a read-only notice instead. - Give the repository tablist aria-selected, a roving tabindex, and arrow-key navigation.
PolicyBuilder writes signed policies to the repo bucket, but the TestController routes that stand in for the CDN locally had no policy endpoint, so client policy fetches always 404ed against a local server.
The Organization prefix was inconsistent with everything else around it: the Policies context, PolicyBuilder, the policy.* audit keys, the /policies routes, and the Policy/RepositoryPolicy proto messages are all unprefixed, and ownership is already expressed by belongs_to. The organization_policies table is renamed to policies in the original migration since the feature is unreleased; already-migrated databases are converged with manual renames.
The CSP plug generates the style-src directive itself when inserting the nonce, and every stylesheet link in the layout carries the nonce, so the emitted policy is nonce-only. Listing 'self' and fonts.googleapis.com as host sources alongside the nonce only allowed un-nonced stylesheets to load, weakening the policy for no benefit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.