Merged
Conversation
5284bf7 to
c72cbfd
Compare
…nvert-method-definitions
c72cbfd to
1c5c81e
Compare
curbengh
approved these changes
Sep 1, 2019
Contributor
|
Just curious, would https://github.com/hexojs/hexo/blob/master/lib/hexo/post.js (and others) benefit from refactor to this style? |
Contributor
Author
|
If you reference |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for conversion to method definition only, because there are many differences in git.
Automatic conversion in lebab does not occur if the constructor is defined in a class declaration.
The first purpose of Revert is to reduce manual conversion.