Merged
Conversation
Pull Request Test Coverage Report for Build 8925325272Details
💛 - Coveralls |
SukkaW
reviewed
May 1, 2024
src/schema.ts
Outdated
| class Schema { | ||
| class Schema<T> { | ||
| paths: Record<string, SchemaType<any>> = {}; | ||
| statics: Record<string, (...args: any[]) => any> = {}; |
Member
There was a problem hiding this comment.
Suggested change
| statics: Record<string, (...args: any[]) => any> = {}; | |
| statics: Record<string, (this: T, ...args: any[]) => any> = {}; |
Is it possible to improve the types here as well? This could achieve stricter type checking.
SukkaW
reviewed
May 1, 2024
src/database.ts
Outdated
| * @return {Model} | ||
| */ | ||
| model(name: string, schema?: Schema | Record<string, AddSchemaTypeOptions>): Model<any> { | ||
| model<T>(name: string, schema?: Schema<T> | Record<string, AddSchemaTypeOptions>): Model<any> { |
Member
There was a problem hiding this comment.
Suggested change
| model<T>(name: string, schema?: Schema<T> | Record<string, AddSchemaTypeOptions>): Model<any> { | |
| model<T = any>(name: string, schema?: Schema<T> | Record<string, AddSchemaTypeOptions>): Model<any> { |
We can assign a default value to any to prevent breaking change (where model previously doesn't require a type argument).
SukkaW
reviewed
May 1, 2024
SukkaW
reviewed
May 1, 2024
SukkaW
approved these changes
May 2, 2024
Member
Author
|
In fact, the Line 12 in 2c89f53 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check list
Description
ref: hexojs/hexo#5483 (comment)
Additional information
How to use it now:
virtualstatic