Conversation
Pull Request Test Coverage Report for Build 8733513242Details
💛 - Coveralls |
tomap
previously approved these changes
Apr 18, 2024
SukkaW
approved these changes
Apr 18, 2024
Member
SukkaW
left a comment
There was a problem hiding this comment.
nanoid LGTM. It is faster and is collision resilient enough.
SukkaW
requested changes
Apr 18, 2024
Comment on lines
31
to
34
| validate(value?: string): string { | ||
| if (value && (value[0] !== 'c' || value.length !== 25)) { | ||
| if (value && (value.length !== 21)) { | ||
| throw new ValidationError(`\`${value}\` is not a valid CUID`); | ||
| } |
Member
There was a problem hiding this comment.
Since the schema of the id has changed, previously generated db.json will become invalid after the PR. It is a breaking change that we might want to avoid.
Let's keep the c prefix, and let the nanoid generate random ids with the size of 24. Now previously generated db.json is still valid and Hexo will not crash.
Member
Author
There was a problem hiding this comment.
That makes sense. I will change its format to be compatible with old cuid.
SukkaW
approved these changes
Apr 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check list
Description
See #147
Additional information