fix: replace JSONStream with jsonstream-next#132
Closed
renbaoshuo wants to merge 1 commit intohexojs:masterfrom
Closed
fix: replace JSONStream with jsonstream-next#132renbaoshuo wants to merge 1 commit intohexojs:masterfrom
JSONStream with jsonstream-next#132renbaoshuo wants to merge 1 commit intohexojs:masterfrom
Conversation
5 tasks
stevenjoezhang
approved these changes
Jul 27, 2022
SukkaW
requested changes
Jul 27, 2022
Member
SukkaW
left a comment
There was a problem hiding this comment.
jsonstream-next is not widely used by the community. We should re-consider before merging this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves hexojs/hexo#5022.
jsonstream-nextis a fork ofJSONStream, and the former is adapted to the new version of Node.js, while the latter has long been archived. Therefore, I recommend switching tojsonstream-next, to solve the problem described in hexojs/hexo#5022.