@dailyrandomphoto
any other attribute that I might've missed?

Coverage decreased (-1.4%) to 95.079% when pulling 02e1e52 on curbengh:html-tag-url into 6155112 on hexojs:master.

@dailyrandomphoto
any other attribute that I might've missed?

I have tested some cases and found no issues.

Just found an edge case for responsive image

<img srcset="elva-fairy-320w.jpg 320w,
             elva-fairy-480w.jpg 480w,
             elva-fairy-800w.jpg 800w"
     sizes="(max-width: 320px) 280px,
            (max-width: 480px) 440px,
            800px"
     src="elva-fairy-800w.jpg" alt="Elva dressed as a fairy">

🤔 Let's see possible approaches:

1. split by space and encode each part
2. regex match string that ends with an image extension (I saw the regex pattern somewhere in hexo, can't find it), then encode it.

@curbengh

/<img [^>]*src=['"]([^'"]+)([^>]*>)/gi

This is the <img> tag pattern used in open_graph() helper.

https://github.com/hexojs/hexo/blob/19ac152ac3fd708b1860244187442c587be73031/lib/plugins/helper/open_graph.js#L62

/<img [^>]src='"([^>]>)/gi

That's actually is the first regex I tried, but it's not applicable here because html_tag is not parsing a html. Essentially, the goal is just to avoid encoding the space in elva-fairy-800w.jpg 800w.

Anyway, the latest fix, while seems overcomplicating stuff, it's to preserve new lines. Frankly, I don't know if anyone actually wants it (new line) 😅 . Personally, I would just go for handleSpaceNewLineMinify() approach of following examples.

function handleSpace(str) {
  return encodeURI(str).replace(/(%20)/g, ' ');
}

function handleSpaceNewLine(str) {
  return encodeURI(str).replace(/(%20|%0A)/g, ' ');
}

function handleSpaceNewLineMinify(str) {
  return encodeURI(str).replace(/%20/g, ' ').replace(/,(%0A|%0D%0A)*\s*/g, ',');
}

let data = `fóo.jpg 320w,
        /foo/bár.jpeg 480w,
        default.png`

console.log(handleSpace(data))
// f%C3%B3o.jpg 320w,%0A        /foo/b%C3%A1r.jpeg 480w,%0A        default.png

console.log(handleSpaceNewLine(data))
// f%C3%B3o.jpg 320w,         /foo/b%C3%A1r.jpeg 480w,         default.png

console.log(handleSpaceNewLineMinify(data))
// f%C3%B3o.jpg 320w,/foo/b%C3%A1r.jpeg 480w,default.png