Deprecated hashStream#45
Merged
segayuu merged 4 commits intohexojs:masterfrom Nov 5, 2018
segayuu:deprecated-hashStream
Merged
Deprecated hashStream#45segayuu merged 4 commits intohexojs:masterfrom segayuu:deprecated-hashStream
segayuu merged 4 commits intohexojs:masterfrom
segayuu:deprecated-hashStream
Conversation
- deprecated HashStream
- result for crypto.createHash() is stream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is divided PR because #35 has become big.
Hashclass It itself inherits theTransformclass. There is no need to go throughHashStream.In addition,
HashStreamimplementation does not assumeobjectMode, andobjectModeis invalid inTransformoptions! (It is controlled byreadableObjectModeandwritableObjectMode)Since the implementation was originally unclear, you can solve the problem by creating a new
createSha1Hash()and migrating it to it.