Skip to content

test: replace nyc with c8#356

Merged
uiolee merged 2 commits intohexojs:masterfrom
uiolee:c8
Aug 31, 2023
Merged

test: replace nyc with c8#356
uiolee merged 2 commits intohexojs:masterfrom
uiolee:c8

Conversation

@uiolee
Copy link
Member

@uiolee uiolee commented Aug 28, 2023

@coveralls
Copy link

coveralls commented Aug 28, 2023

Coverage Status

coverage: 95.249% (-0.2%) from 95.422% when pulling 8ffbbba on uiolee:c8 into 7dda4e5 on hexojs:master.

@uiolee
Copy link
Member Author

uiolee commented Aug 28, 2023

coverage in ci is lower than that in my pc

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO:

We should change the filename from .nycrc.json to .c8rc.json.

refs: https://github.com/bcoe/c8/tree/a13584d5be5259ebb6a00455d352c3e8b16006de#cli-options--configuration

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, i think so

@uiolee uiolee merged commit d090bd2 into hexojs:master Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants