fix(url_for): some improvement for url_for#307
Merged
uiolee merged 12 commits intohexojs:masterfrom Jan 12, 2024
Merged
Conversation
Property 'fromEntries' does not exist on type 'ObjectConstructor' Property 'matchAll' does not exist on type 'string'
- sometimes `postinstall` not triggered when using `yarn` v3
chore(url_for): make `options` as optional - keep `empty object` for default options - sometimes i saw someone plugin fill `options` null, to prevent useless errors we must give options fallback to `empty object`
Contributor
Author
|
@SukkaW review pls |
SukkaW
reviewed
May 13, 2023
highlight.js no need build everytime
url_for
| trailing_index: true, | ||
| trailing_html: true | ||
| }, config.pretty_urls); | ||
| const prettyUrlsOptions = Object.assign( |
Member
There was a problem hiding this comment.
You can keep the original code style here
Member
There was a problem hiding this comment.
Looks like he used prettier. If eslint doesn't fail, I guess it doesn't matter.
url_forurl_for
SukkaW
reviewed
Dec 22, 2023
[skip ci] Co-authored-by: Sukka <isukkaw@gmail.com>
uiolee
approved these changes
Dec 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore: some improvement for
url_foroptionsas optional with default value asempty objectoptions- https://github.com/next-theme/hexo-theme-next/blob/acca4e83747b168e90815945f58f982b1d14eac5/layout/_layout.njk#L10optionsfallback to anempty objecturl_fortheoptionsgiven asnull, prevent useless error giveoptionsfallback to anempty object