Skip to content

refactor: completely rewrite the logger#34

Merged
SukkaW merged 12 commits intohexojs:masterfrom
SukkaW:fancy-log
May 29, 2020
Merged

refactor: completely rewrite the logger#34
SukkaW merged 12 commits intohexojs:masterfrom
SukkaW:fancy-log

Conversation

@SukkaW
Copy link
Member

@SukkaW SukkaW commented Apr 25, 2020

Since hexo-bunyan is too heavy and hard to maintained, I have rewritten a new logger with nearly the same behavior (except debug.log file output). So far the unit test is not finished yet. Coverage is now 100%.

@coveralls
Copy link

coveralls commented Apr 25, 2020

Coverage Status

Coverage increased (+5.4%) to 100.0% when pulling 44b0d4a on SukkaW:fancy-log into 4d9063e on hexojs:master.

@SukkaW SukkaW requested a review from yoshinorin May 5, 2020 14:05
Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Copy link
Contributor

@curbengh curbengh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on dummy blog.

@yoshinorin
Copy link
Member

@SukkaW
May we merge this ?
I can publish new major version any time we want.

@SukkaW
Copy link
Member Author

SukkaW commented May 29, 2020

@yoshinorin Sure!

@SukkaW SukkaW merged commit 17205df into hexojs:master May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants