Skip to content

chore: cast type ConsoleArgs to any[]#148

Merged
renbaoshuo merged 4 commits intohexojs:masterfrom
dimaslanjaka:master
May 10, 2023
Merged

chore: cast type ConsoleArgs to any[]#148
renbaoshuo merged 4 commits intohexojs:masterfrom
dimaslanjaka:master

Conversation

@dimaslanjaka
Copy link
Contributor

@dimaslanjaka dimaslanjaka commented May 6, 2023

fixed for logging an object in typescript.

type non string is not assignable to type 'string'.ts(2322)

example

hexo.log.info('logname', { prop: 'value' });

error

Type '{ prop: string }' is not assignable to type 'string'. ts(2345)

@dimaslanjaka
Copy link
Contributor Author

@SukkaW review pls

because just wrapper of `console.log`

Co-authored-by: Sukka <isukkaw@gmail.com>
@dimaslanjaka dimaslanjaka changed the title cast type ConsoleArgs to any[] chore: cast type ConsoleArgs to any[] May 10, 2023
@coveralls
Copy link

Coverage Status

Coverage: 98.413%. Remained the same when pulling 3e1f6b6 on dimaslanjaka:master into 97b563f on hexojs:master.

Copy link
Member

@renbaoshuo renbaoshuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@renbaoshuo renbaoshuo merged commit d20a133 into hexojs:master May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants