Skip to content

refactor: migrate typescript#119

Merged
yoshinorin merged 12 commits intomasterfrom
refactor/replace-typescript
Oct 28, 2022
Merged

refactor: migrate typescript#119
yoshinorin merged 12 commits intomasterfrom
refactor/replace-typescript

Conversation

@yoshinorin
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Sep 18, 2022

Coverage Status

Coverage increased (+0.03%) to 98.413% when pulling efbff2e on refactor/replace-typescript into 8f9dff3 on master.

@yoshinorin yoshinorin marked this pull request as ready for review September 18, 2022 17:12
@yoshinorin yoshinorin changed the title [WIP] refactor: migrate typescript refactor: migrate typescript Sep 18, 2022
@yoshinorin
Copy link
Member Author

@hexojs/core
Maybe ready. I think we can improve more type-safe. But, I want to merge this once before brush-up.

}

module.exports = createLogger;
export const logger = (option: Options) => createLogger(option);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's suitable here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'll check it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@renbaoshuo
Done. Ready :)

@yoshinorin yoshinorin requested a review from renbaoshuo October 3, 2022 16:09
@yoshinorin yoshinorin merged commit a0ce3ee into master Oct 28, 2022
@yoshinorin yoshinorin deleted the refactor/replace-typescript branch October 28, 2022 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants