update all packages to latest and include package-lock.json#50
Merged
yoshinorin merged 2 commits intohexojs:masterfrom Mar 12, 2019
Merged
update all packages to latest and include package-lock.json#50yoshinorin merged 2 commits intohexojs:masterfrom
yoshinorin merged 2 commits intohexojs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the issues with a dependency that broke hexo-cli, it seems indispensible to include package-lock.json
For other repository of hexojs project, it is less important, but for this project, it is indispensible, because user have no easy possibility to lock dependency to a specific version as this project is supposed to be installed globaly
For reference, see #49 and linked issues