Closed
Conversation
segayuu
requested changes
Oct 7, 2018
Contributor
segayuu
left a comment
There was a problem hiding this comment.
Thank @yoshinorin for always PR.
However, the version difference of sinon package is too large for this PR.
I appreciate that you confirmed breaking change, but unless you are from sinon package standalone version upgrade only or upgrading sinon@3 with only one breaking change, I will not admit this PR. sorry.
Member
Author
|
@segayuu |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update devDependencies and fix some tests
callsFakeinstead of it.resetHistoryinstead of it.